Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken example link in readme.md #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ethagnawl
Copy link

Fix broken link to example in README

Fix broken link to example in README
@ethagnawl ethagnawl changed the title Update readme.md Fix broken example link in readme.md Dec 7, 2018
@peteygao
Copy link

Technically the text should also be changed, since it's no longer an Emoji Chat Room demo, rather the example is an embedded Elm clock.

@ethagnawl
Copy link
Author

Good point, @peteygao.

This is orthogonal to this PR, but while we're at it, I also had to do a bit of work to get the latest example working on my machine (updating react/dom, removing emojione-picker and using the published version of the library -- as opposed to the relative path). If the maintainers would be interested, I'd be happy to submit an additional PR containing those changes.

@peteygao
Copy link

@ethagnawl 👍

Really hoping all these improvement PR's are going to get merged by the repo maintainer(s) at some point. I'm having to do this manually in a forked repo to include all the fixes to present to my colleagues (we're using React, and I'd love to slowly introduce Elm).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants