Add a flag to optionally disable variable translation #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pda
reviewed
Sep 25, 2018
| @@ -18,6 +19,7 @@ import ( | |||
|
|
|||
| const ( | |||
| pathEnv = "PARAMETER_STORE_EXEC_PATH" | |||
| disableTranslation = "PARAMETER_STORE_EXEC_DISABLE_TRANSLATION" | |||
There was a problem hiding this comment.
I try to avoid “disable = true”.
Perhaps PARAMETER_STORE_EXEC_VERBATIM=true?
Or perhaps PARAMETER_STORE_EXEC_TRANSFORM=none, which leaves room for the default upper and perhaps future transform modes (e.g. maybe one that doesn't trim the prefix at all).
|
Thanks for the PR @kmanning, great to see. |
|
This was closed because of inactivity, but there doesn't seem to be an issue aside from an outstanding comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking a swing at an implementation for Issue #4