fix(Pagination): Tighten margins and reduce pages shown to make usable on 320px #5269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3526455 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dougmacknz
force-pushed
the
KZN-2739/pagination-responsiveness
branch
from
abf84d5 to
5659587
Compare
dougmacknz
force-pushed
the
KZN-2739/pagination-responsiveness
branch
from
5659587 to
a1c6434
Compare
dougmacknz
commented
Nov 12, 2024
| @@ -51,15 +51,3 @@ | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| // Truncate indicator | |||
| .truncateIndicatorWrapper { | |||
There was a problem hiding this comment.
Wasn't being used at all, It got split out and copied into it's own component and I guess they forgot to delete this
HeartSquared
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Pagination currently overflows 320px
What
Screen.Recording.2024-11-12.at.2.08.07.PM.mov