Skip to content

Commit

Permalink
internal/core/adt: disable dereference for new evaluator
Browse files Browse the repository at this point in the history
Recent changes were dereferencing was introduced elsewhere
make this use unnecessary.

Keep this in a separate CL to allow tracking possible bugs
this introduces.

Issue #2884
Issue #2854

Signed-off-by: Marcel van Lohuizen <[email protected]>
Change-Id: Iffbbbb3bef513205a0f6a29571bc6c6a37692bb1
  • Loading branch information
mpvl committed May 1, 2024
1 parent 997439a commit 7dacabf
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions internal/core/adt/context.go
Original file line number Diff line number Diff line change
Expand Up @@ -511,8 +511,8 @@ func (c *OpContext) Lookup(env *Environment, r Resolver) (*Vertex, *Bottom) {

err := c.PopState(s)

if arc != nil {
// TODO(P1)/TODO(deref): lookup should probably not use DerefValue, but
if arc != nil && !c.isDevVersion() {
// TODO(deref): lookup should probably not use DerefValue, but
// rather only dereference disjunctions.
arc = arc.DerefValue()
}
Expand Down

0 comments on commit 7dacabf

Please sign in to comment.