Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move examples #129

Merged
merged 4 commits into from
Oct 10, 2022
Merged

Move examples #129

merged 4 commits into from
Oct 10, 2022

Conversation

aslakhellesoy
Copy link
Contributor

@aslakhellesoy aslakhellesoy commented Oct 10, 2022

🤔 What's changed?

The example code has moved to https://github.com/cucumber/screenplay.js.examples

⚡️ What's your motivation?

The example code itself has a lot of dependencies and makes it difficult to upgrade dependencies. Plus, it's quite complicated. We could add back a simpler example in this repo without dependencies on @cucumber/electron, react etc...

This fixes #127

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

♻️ Anything particular you want feedback on?

Right now there are no tests (apart from a test for eventually). We should add back some unit tests as well as a simple Cucumber example.

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@aslakhellesoy aslakhellesoy merged commit dab945e into main Oct 10, 2022
@aslakhellesoy aslakhellesoy deleted the move-examples branch October 10, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove electron from Example code
1 participant