Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omit documents with no test cases from results #321

Merged
merged 3 commits into from
Nov 25, 2022

Conversation

davidjgoss
Copy link
Contributor

🤔 What's changed?

Use the list of statuses with scenarios that actually ran as a base for filtering Gherkin documents.

We sort of half-fixed this in #273, but needed to also feed the list of appropriate status to the document filter so that it doesn't show documents when nothing from them ran.

Using the example of a test run where several documents were found but only one scenario ran (e.g. because of a name or tag filter):

Before

image

After

image

⚡️ What's your motivation?

Fixes cucumber/html-formatter#49

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React isn't my strong suit but see no problems.

@davidjgoss davidjgoss merged commit 4937cf1 into main Nov 25, 2022
@davidjgoss davidjgoss deleted the fix/filtered-out-pickles-take-2 branch November 25, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude 'unknown' scenarios from html report
2 participants