-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new methods for attachments, hooks, meta #67
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidjgoss
force-pushed
the
new-methods-for-react
branch
from
January 3, 2025 00:00
4a5a645
to
48e346d
Compare
davidjgoss
force-pushed
the
new-methods-for-react
branch
from
January 3, 2025 08:52
48e346d
to
a541c36
Compare
davidjgoss
changed the title
Add new methods for attachments and hooks
Add new methods for attachments, hooks, meta
Jan 3, 2025
mpkorstanje
reviewed
Jan 12, 2025
mpkorstanje
reviewed
Jan 12, 2025
mpkorstanje
requested changes
Jan 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Few nitpicks. Feel free to merge after addressing these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Adds three new methods in our polyglot, test case-centric interface:
findAttachmentsBy(TestStepFinished)
returns an array of attachments.TestStepFinished
makes the most sense as the starting point because it has both thetestStepId
to identify the step, and thetestCaseStartedId
to identify the test case attempt.findHookBy(TestStep)
returns an optionalHook
, natural cousin offindPickleStepBy(TestStep)
findMeta()
returns the Meta message if presentAlso, fixes a bug in the old attachment-related method in JavaScript, which made an assumption an attachment would always be tied to a
testStepId
, which will not be the case once cucumber/messages#102 is implemented in runners.⚡️ What's your motivation?
Required for work on React components for the HTML formatter in cucumber/html-formatter#283
🏷️ What kind of change is this?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.