Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve regexp flags #92

Merged
merged 5 commits into from
Sep 10, 2022
Merged

Preserve regexp flags #92

merged 5 commits into from
Sep 10, 2022

Conversation

aslakhellesoy
Copy link
Contributor

🤔 What's changed?

RegExp flags such as /^a case insensitive step is invoked$/i so that Gherkin steps are correctly matched.

⚡️ What's your motivation?

See #91 (comment)

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@aslakhellesoy aslakhellesoy merged commit c33d5cf into main Sep 10, 2022
@aslakhellesoy aslakhellesoy deleted the preserve-regexp-flags branch September 10, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aslakhellesoy