Fix/csharp cucumber expression support

[Issafalcon]

🤔 What's changed?

• Updating c-sharp language support to be able to recognise cucumber expression syntax and non-verbatim string literal expressions

⚡️ What's your motivation?

• To fix Non-verbatim C# expressions are not recognized #62 and SpecFlow step definitions with parametrized cucumber expressions are not recognized #63

🏷️ What kind of change is this?

• ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

The ExpressionBuilder tests fail on the fact the string literal expressions are returned with double quotes instead of single quotes. I'm not sure how to get past this particular failure (or at least, where best to place the correction for it)

📋 Checklist:

• I agree to respect and uphold the Cucumber Community Code of Conduct
• I've changed the behaviour of the code
  • I have added/updated tests to cover my changes.
    - [ ] My change requires a change to the documentation.
    ~ - [ ] I have updated the documentation accordingly.~
• [s] Users should know about my change
  • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

---

This text was originally generated from a template, then edited by hand. You can modify the template here.

[aslakhellesoy]

Please remove this or make it consistent with step definitions for the other languages. Ref point 4 in CONTRIBUTING.md.

There is a test that expects exact expressions:

language-service/test/language/ExpressionBuilder.test.ts

Line 58 in b7e8b98

assert.deepStrictEqual(expressions, ['a {uuid}', 'a {date}', /^a regexp$/])

[Issafalcon]

I see. I'll update this. What are your thoughts on this [When(@"I have Regex parameters like (\d+) and (\d+)")] expression out of interest? It is a common pattern in the Specflow generated step definitions (using the Visual Studio Specflow extension), so I'm wondering if it's OK to not have it included here as part of the testing.

[aslakhellesoy]

Thanks for looking into this! I've left a comment about what needs to be fixed.

[aslakhellesoy]

Also, please add c_sharp to

language-service/test/language/ExpressionBuilder.test.ts

Line 12 in b7e8b98

const parameterTypeSupport: Set<LanguageName> = new Set(['typescript', 'java', 'ruby'])

[Issafalcon]

Thanks for the review @aslakhellesoy ! The tests still fail on the expectations of a double quoted string as opposed to single quotes. I'm not sure what the best way to resolve this is.

[aslakhellesoy]

Superseded by #68