Index failure with partial Python parameter match #196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
⚡️ What's your motivation?
The Parameter Type tree-sitter query for Python allowed three optional keyword arguments, 1 for the name argument and 2 for the regular expressions argument in two different formats (
string
andconcatenated-string
).This works fine with valid parameter type definitions using the keyword arguments in the order in which they are declared. However, the query fails in the following scenarios:
name
orregexp
as keyword arguments yields a partial match (as the query specifies more arguments as optional), however the language service requires both and yields an unhandled exception as a result which prevents reading from all glue files entirely.🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.