Go step definitions support #130

mirogta · 2023-02-27T01:23:52Z

🤔 What's changed?

Added support for Go (https://github.com/cucumber/godog) - this should fix Add support for Go (Godog) #72

Used https://tree-sitter.github.io/tree-sitter/playground to figure out the syntax tree.

godog doesn't have support for Parameter Types so not using it. (The other BDD library in Go, https://github.com/go-bdd/gobdd has support for Parameter Types, but it's obsolete…)

godog doesn't use Given, When or Then keywords, but instead a generic Step keyword.

You probably don't want .vscode/launch.json and .vscode/settings.json committed, but I've left it there for my own sake to be able to debug this faster. Happy to remove them for the final commit before merging.

⚡️ What's your motivation?

To make this finally usable in Go

🏷️ What kind of change is this?

⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

Unit tests are passing… I'm new to vscode extension development, so please bear with me.
I'm trying to follow this and have added go support to both cucumber/language-server and cucumber/vscode locally, but somehow I can't get it work. Can someone please advise how do I debug that? The guide in cucumber/vscode says "Chose Run -> Run without debugging".

📋 Checklist:

I agree to respect and uphold the Cucumber Community Code of Conduct
I've changed the behaviour of the code
- I have added/updated tests to cover my changes.
My change requires a change to the documentation.
- I have updated the documentation accordingly.
Users should know about my change
- I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

CodiumAI-Agent · 2023-07-16T21:32:34Z

How to use PR-Agent

Tag me in a comment '@CodiumAI-Agent' and add one of the following commands:
/review - Request a review of the latest update to the PR.
/describe - Modify the PR title and description based on the contents of the PR.
/improve - Suggest improvements to the code in the PR. These will be provided as pull request comments, ready to commit.
/ask - Pose a question about the PR.

GadiZimerman · 2023-07-16T21:35:03Z

@CodiumAI-Agent /review

CodiumAI-Agent · 2023-07-16T21:35:55Z

PR Analysis

🎯 Main theme: Adding support for Go language
📌 Type of PR: Enhancement
🧪 Relevant tests added: Yes
✨ Focused PR: Yes, the PR is focused as it is primarily concerned with adding support for the Go language. The title and description clearly state this, and the code changes align with this objective.
🔒 Security concerns: No, the PR does not introduce any obvious security concerns. It primarily involves adding support for a new language and does not deal with user input or database operations.

PR Feedback

💡 General PR suggestions: The PR is well-structured and the changes are well-documented. However, there are some .vscode settings files included in the PR that might not be necessary for the project and could be removed before merging. Also, it would be beneficial to add more detailed comments in the new Go language support code for better maintainability.

How to use

Tag me in a comment '@CodiumAI-Agent' and add one of the following commands:
/review - Request a review of the latest update to the PR.
/describe - Modify the PR title and description based on the contents of the PR.
/improve - Suggest improvements to the code in the PR. These will be provided as pull request comments, ready to commit.
/ask - Pose a question about the PR.

src/language/goLanguage.ts

src/tree-sitter-node/NodeParserAdapter.ts

cpunion · 2023-08-24T09:51:58Z

What is the status of this PR?

iamNoah1 · 2023-09-21T09:35:06Z

hei @mirogta wanna to check in what the progress is here and if you need some help by any chance?!

mirogta · 2023-09-21T17:22:17Z

@cpunion @iamNoah1 - if this looks abandoned, that's because I had other priorities. Happy for anyone else to pick this up and continue/get it done. I won't have bandwidth for it anytime soon.

lucas-deangelis · 2023-10-11T15:42:09Z

What are the current blockers for this PR to be merged? I'm assuming that the first two comments raised by @CodiumAI-Agent should be fixed, but the third is not specific to the integration of Go, but I'm not certain. Is there anything else needed?

CodiumAI-Agent · 2023-10-11T15:42:25Z

How to use PR-Agent

Tag me in a comment '@CodiumAI-Agent' and add one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback.
/ask <QUESTION>: Pose a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.

mirogta · 2023-10-12T22:01:04Z

What are the current blockers for this PR to be merged? I'm assuming that the first two comments raised by @CodiumAI-Agent should be fixed, but the third is not specific to the integration of Go, but I'm not certain. Is there anything else needed?

That + the two branch conflicts + running a test that this actually works

CodiumAI-Agent · 2023-10-12T22:01:21Z

How to use PR-Agent

Tag me in a comment '@CodiumAI-Agent' and add one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback.
/ask <QUESTION>: Pose a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.

- Support for new 'Given', 'When', 'Then' step definitions - Support for 'interpreted_string_literal' with tree-sitter - Support tree-sitter-go v0.20.0 - Changed Go snippet implementation away from Rust version - Removed Rust snippet string prefix check from Go implementation - Removed commented Go language support code - Missing 'expression_statement' in tree-sitter query - Redundant VSCode extension settings - Redundant Go testdata lock files

kieran-ryan · 2024-04-07T13:42:18Z

Sincere thanks for this contribution @mirogta! We'll roll this into a coming release. Have tested and made the following changes:

Support for Given, When and Then step definition keywords - introduced through Implement unambiguous keywords godog#509
Support for interpreted_string_literal ("the bee's knees") further to raw_string_literal (^a regexp$)
Added required expression_statement to the tree-sitter query
Removed the VSCode extension settings, Go test data lock files; and commented code highlighted by @CodiumAI-Agent
Bumped tree-sitter-go to v0.20.0
Replaced Rust step definition in Go implementation with a Go sample
Added unit test for the Go string literal function

I'm trying to follow this and have added go support to both cucumber/language-server and cucumber/vscode locally, but somehow I can't get it work. Can someone please advise how do I debug that? The guide in cucumber/vscode says "Chose Run -> Run without debugging".

Have recently overhauled the VSCode extension contributing guidelines, feel free to give it a go and raise a PR or issue if any improvements or feedback.

aslakhellesoy · 2024-04-07T13:49:53Z

Hi @mirogta,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

Add support for go

1942d13

mirogta mentioned this pull request Feb 27, 2023

Add support for Go (Godog) #72

Closed

Update changelog - added support for go

cf27cce

mirogta marked this pull request as ready for review February 27, 2023 23:09

mirogta and others added 3 commits February 27, 2023 23:09

Merge branch 'main' into add-go-godog

4e71008

Merge branch 'main' into add-go-godog

5426ae4

Merge branch 'main' into add-go-godog

1e146dd

CodiumAI-Agent reviewed Jul 16, 2023

View reviewed changes

src/language/goLanguage.ts Outdated Show resolved Hide resolved

CodiumAI-Agent reviewed Jul 16, 2023

View reviewed changes

src/language/goLanguage.ts Show resolved Hide resolved

CodiumAI-Agent reviewed Jul 16, 2023

View reviewed changes

src/tree-sitter-node/NodeParserAdapter.ts Show resolved Hide resolved

kieran-ryan added the ⚡ enhancement Request for new functionality label Jan 7, 2024

kieran-ryan assigned kieran-ryan and unassigned kieran-ryan Jan 21, 2024

kieran-ryan mentioned this pull request Apr 6, 2024

Godog support cucumber/language-server#106

Merged

3 tasks

kieran-ryan added 2 commits April 6, 2024 23:44

Merge branch 'main' into add-go-godog

0188aea

kieran-ryan self-assigned this Apr 7, 2024

kieran-ryan changed the title ~~Add support for go~~ Godog step definitions support Apr 7, 2024

kieran-ryan changed the title ~~Godog step definitions support~~ Go step definitions support Apr 7, 2024

kieran-ryan approved these changes Apr 7, 2024

View reviewed changes

kieran-ryan merged commit 9c4cec5 into cucumber:main Apr 7, 2024
6 checks passed

mirogta deleted the add-go-godog branch April 9, 2024 13:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Go step definitions support #130

Go step definitions support #130

mirogta commented Feb 27, 2023 •

edited

Loading

CodiumAI-Agent commented Jul 16, 2023

GadiZimerman commented Jul 16, 2023

CodiumAI-Agent commented Jul 16, 2023

cpunion commented Aug 24, 2023

iamNoah1 commented Sep 21, 2023

mirogta commented Sep 21, 2023

lucas-deangelis commented Oct 11, 2023

CodiumAI-Agent commented Oct 11, 2023

mirogta commented Oct 12, 2023

CodiumAI-Agent commented Oct 12, 2023

kieran-ryan commented Apr 7, 2024

aslakhellesoy commented Apr 7, 2024

Go step definitions support #130

Go step definitions support #130

Conversation

mirogta commented Feb 27, 2023 • edited Loading

🤔 What's changed?

⚡️ What's your motivation?

🏷️ What kind of change is this?

♻️ Anything particular you want feedback on?

📋 Checklist:

CodiumAI-Agent commented Jul 16, 2023

How to use PR-Agent

GadiZimerman commented Jul 16, 2023

CodiumAI-Agent commented Jul 16, 2023

PR Analysis

PR Feedback

How to use

cpunion commented Aug 24, 2023

iamNoah1 commented Sep 21, 2023

mirogta commented Sep 21, 2023

lucas-deangelis commented Oct 11, 2023

CodiumAI-Agent commented Oct 11, 2023

How to use PR-Agent

mirogta commented Oct 12, 2023

CodiumAI-Agent commented Oct 12, 2023

How to use PR-Agent

kieran-ryan commented Apr 7, 2024

aslakhellesoy commented Apr 7, 2024

mirogta commented Feb 27, 2023 •

edited

Loading