Skip to content

Commit

Permalink
Drop support for end-of-life node version 16 (#224)
Browse files Browse the repository at this point in the history
* Drop node v16

* Use 'npm ci' in pipeline

* Changelog drop Node v16
  • Loading branch information
kieran-ryan authored Jul 13, 2024
1 parent 0d28333 commit 92bb6eb
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 8 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/release-npm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,11 @@ jobs:
version: 2.0.24
- uses: actions/setup-node@v4
with:
node-version: '16'
node-version: '18'
cache: 'npm'
cache-dependency-path: package-lock.json
- run: npm install-test
- run: npm ci
- run: npm run test
- uses: cucumber/[email protected]
with:
npm-token: ${{ secrets.NPM_TOKEN }}
9 changes: 3 additions & 6 deletions .github/workflows/test-javascript.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,7 @@ jobs:
- macos-latest
- ubuntu-latest
- windows-latest
# 14.x is broken with @typescript-eslint 6.0
# 16.12.0 has broken ESM support
# 17.x cannot install tree-sitter: https://github.com/tree-sitter/tree-sitter/issues/1503
node-version: ['16.11.x', '18.x']
node-version: ['18.x']

steps:
- name: set git core.autocrlf to 'input'
Expand All @@ -40,9 +37,9 @@ jobs:
node-version: ${{ matrix.node-version }}
cache: 'npm'
cache-dependency-path: package-lock.json
- run: npm install
- run: npm ci
if: ${{ matrix.os != 'windows-latest' }}
- run: npm install --no-optional
- run: npm ci --no-optional
if: ${{ matrix.os == 'windows-latest' }}
- run: npm test
- run: npm run eslint
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- (PHP) Scoped query to match annotations only (`@Given`) ([#214](https://github.com/cucumber/language-service/pull/214))
- (Go) Find godog step definitions within `method_declaration` ([#215](https://github.com/cucumber/language-service/pull/215))

### Removed
- Dropped support for end-of-life Node version 16 ([#224](https://github.com/cucumber/language-service/pull/224))

## [1.6.0] - 2024-05-12
### Added
- Diagnostics for marking steps as undefined in scenario outlines ([#210](https://github.com/cucumber/language-service/pull/210))
Expand Down

0 comments on commit 92bb6eb

Please sign in to comment.