-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing execution steps statuses if same step is called multiple times in a test #24
Conversation
…d of LinkedHashMap<String, String>, to prevent crushing a step result with another step with same name result
CHANGELOG.md
Outdated
@@ -6,6 +6,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|||
## [Unreleased] | |||
[0.2.1]: https://github.com/cucumber/cucumber-junit-xml-formatter/pull/24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the version number, and used the ### Fixed
header. We use the format from https://keepachangelog.com.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks good!
But please clean up the issue name/pull request title, and put that in the changelog a long with a reference to the issue.
Typically a good issue name, and good change log entry follow the guidelines of a good commit title.
Please also look at the existing entries and ensure consistency.
@mpkorstanje Thanks for the review ! I Think I did the requested changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Cheers!
I currently don't have Ethernet and USB tethering to my phone doesn't work. I'll release this asap.
Hi @fahadi-henix, Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾 In return for this generous offer we hope you will:
On behalf of the Cucumber core team, |
🤔 What's changed?
The xml report formatter now returns the same number of step results as the number of steps in a cucumber test, even if some steps have the same name.
In code :
XmlReportData.getStepsAndResult()
now returns aList<Map.Entry<String, String>>
instead of aLinkedHashMap<String, String>
XmlReportWriter.createStepResultList()
now take aList<Map.Entry<String, String>>
instead of aLinkedHashMap<String, String>
as parameter⚡️ What's your motivation?
Fixes: #23
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.