Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix afterscenario attachments #646

Merged
merged 4 commits into from
Oct 6, 2024
Merged

Conversation

Johnlon
Copy link
Member

@Johnlon Johnlon commented Oct 6, 2024

🤔 What's changed?

Small change to enable attachments from "after scenario" hook

⚡️ What's your motivation?

Bug fix - functionality

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

Copy link

github-actions bot commented Oct 6, 2024

Go API Changes

# github.com/cucumber/godog
## compatible changes
Attach: added
Attachment: added
Attachments: added
ErrAmbiguous: added
StepAmbiguous: added

# github.com/cucumber/godog/formatters
## incompatible changes
Formatter.Ambiguous: added

# summary
Inferred base version: v0.14.1
Suggested version: v0.15.0

@Johnlon Johnlon merged commit 8edde7f into main Oct 6, 2024
5 checks passed
@Johnlon Johnlon deleted the bugfix-afterscenario-attachments branch October 6, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant