Update CI for go1.20 #552
Merged
Update CI for go1.20 #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go API Changes# github.com/cucumber/godog ## compatible changes (*ScenarioContext).Given: added (*ScenarioContext).Then: added (*ScenarioContext).When: added # github.com/cucumber/godog/formatters ## compatible changes Given: added Keyword: added None: added StepDefinition.Keyword: added Then: added When: added # summary Inferred base version: v0.12.6 Suggested version: v0.13.0 |
Codecov Report
@@ Coverage Diff @@
## main #552 +/- ##
=======================================
Coverage 82.94% 82.94%
=======================================
Files 28 28
Lines 3371 3371
=======================================
Hits 2796 2796
Misses 461 461
Partials 114 114
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
vearutop
added a commit
that referenced
this pull request
Apr 3, 2023
#549) * Update CI for go1.20 (#552) * fix(deps): update module github.com/cucumber/gherkin/go/v26 to v26.1.0 * Tidy modules --------- Co-authored-by: Viacheslav Poturaev <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
vearutop
added a commit
that referenced
this pull request
Apr 3, 2023
* fix(deps): update module github.com/cucumber/gherkin/go/v26 to v26.1.0 (#549) * Update CI for go1.20 (#552) * fix(deps): update module github.com/cucumber/gherkin/go/v26 to v26.1.0 * Tidy modules --------- Co-authored-by: Viacheslav Poturaev <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * cancel context for each scenario * Update suite.go --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Viacheslav Poturaev <[email protected]> Co-authored-by: Viacheslav Poturaev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
This PR updates CI jobs to use latest version of Go and changes tests to accommodate for golang/go#51774.
Resolves #551.
⚡️ What's your motivation?
It has been a while since we've bumped version of Go in CI mostly due to a breaking change in
runtime.FuncForPCfile/line resolution introduced in go1.18.🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
Nothing here.
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.