Add a check for missing test files and raise a more helpful error

[ALCooper12]

🤔 What's changed?

• Added a check for missing test files and raised a more helpful error

Fixes #383.

⚡️ What's your motivation?

• trying to fix Incorrect project structure gives an unhelpful error message #383

🏷️ What kind of change is this?

• 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

• I agree to respect and uphold the Cucumber Community Code of Conduct
• I've changed the behaviour of the code
  • I have added/updated tests to cover my changes.
• Users should know about my change
  • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

---

This text was originally generated from a template, then edited by hand. You can modify the template here.

[mattwynne]

@vearutop I am a bit stuck on how to advise @ALCooper12 to actually fix this. We've got it trapped with a failing test around Builder.Build as you suggested in Slack a few weeks ago.

It appears that the unexpected error we're seeing is because the compilerCfg file (importcfg.link) is missing from the build directory. The code beneath here assumes that there will be a file at compilerCfg but in fact that file is only copied if we go into the if statement here.

I don't really understand how we end up in this situation just because the user has called their file main.go instead of main_test.go!?

Can you shed any light on it?

[ALCooper12]

I still need to update the change log, but otherwise this is ready!
Please be gentle with feedback lolz

[codecov]

Codecov Report

Merging #468 (5468a92) into main (237a855) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #468      +/-   ##
==========================================
+ Coverage   81.41%   81.42%   +0.01%     
==========================================
  Files          27       27              
  Lines        2195     2197       +2     
==========================================
+ Hits         1787     1789       +2     
  Misses        312      312              
  Partials       96       96              

Impacted Files	Coverage Δ
internal/builder/builder.go	55.02% <100.00%> (+0.43%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 237a855...5468a92. Read the comment docs.

[mattwynne]

@vearutop any feedback?

[vearutop]

I have a minor suggestion, overall this looks good to me! 👍

[aslakhellesoy]

Hi @ALCooper12,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
• 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

[mattwynne]

🎉 congrats @ALCooper12 and thanks for all your hard work and patience figuring out this fix together. I've learned a lot about Go and godog's codebase working with you, I hope we can continue working together!