-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use 'go get' instead of 'go install' to install #449
Conversation
Codecov Report
@@ Coverage Diff @@
## main #449 +/- ##
=======================================
Coverage 81.42% 81.42%
=======================================
Files 26 26
Lines 2175 2175
=======================================
Hits 1771 1771
Misses 311 311
Partials 93 93 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@dmitris could you also update CHANGELOG.md? |
@vearutop updated, the CHANGELOG please take a look btw. the links to both CONTRIBUTING and CHANGELOG are both wrong/dead in the Checklist in the PR template above - I didn't see where the file for that template is located, maybe you could fix it? Thanks. |
Hi @dmitris, Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾 In return for this generous offer we hope you will:
On behalf of the Cucumber core team, |
Thanks @dmitris! We're actively looking for more people to help maintain GoDog, so if you're interested in getting more involved, I'd love to help make that happen. You're welcome to join us in our community Slack in the #committers channel 😄 or the #commiters-go channel. I'm also making myself available for live pairing ⚡ you can book a slot with me here if you want to work on something or just chat about how to get involved. |
thanks @aslakhellesoy and @mattwynne, very nice of you to be so welcoming, I will definitely look for opportunities to contribute to GoDog! |
Description
PR modifies the README.md to use the modern
go install
instead of the deprecatedgo get
method to install the binary.Motivation & context
https://go.dev/doc/go-get-install-deprecation
Type of change
minor documentation change
Note to other contributors
If your change may impact future contributors, explain it here, and remember to update README.md and CONTRIBUTING.md accordingly.
Update required of cucumber.io/docs
If the Cucumber documentation will require an update,
submit an issue or ideally a pull request to cucumber/docs and
reference it here.
e.g. "Ref: cucumber/docs/pull/#99"
Checklist: