-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update gherkin-go to v19.0.3 #402
Conversation
update messages-go to v16.0.1 bump gomod version comment on log line in std os.Stderr examples to non rc version go mod tidy update circle (tbd)
@mattwynne c this should fix the issues found on the other branch. |
Great work @mbow! This looks good to me, and if you think it's ready to merge I'll do it @mbow. We're discussing a merge of godog/gobdd over in the #committers-go channel in the Cucumber slack - any chance you could join the discussion there? |
@mbow - this looks good to me :) |
@aslakhellesoy think the circle builds need to be triggered as maybe that change won't work ( new default images for circle and took a quick guess ) |
I don't understand why CircleCI is not building this branch. I'm going to merge it anyway, and if there are any problems with the build hopefully we can just sort them out in the main branch, once you have the commit bit @mbow. Thanks a lot! |
Hi @mbow, Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾 In return for this generous offer we hope you will:
On behalf of the Cucumber core team, |
update messages-go to v16.0.1
bump gomod version
comment on log line in std os.Stderr
examples to non rc version
go mod tidy
update circle (tbd)
Description
fixes for #390
this branch is to fix panics on an update of library versions due to getter methods being removed and default values are nil.
If it fixes an open issue #396
this should close a CVE in the above lib and allow use in orgs that scan for CVE's
Type of change
Checklist: