Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gherkin-go to v19.0.3 #402

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

mbow
Copy link

@mbow mbow commented Jun 28, 2021

update messages-go to v16.0.1
bump gomod version
comment on log line in std os.Stderr
examples to non rc version
go mod tidy
update circle (tbd)

Description

fixes for #390
this branch is to fix panics on an update of library versions due to getter methods being removed and default values are nil.

"github.com/cucumber/gherkin-go/v19"
"github.com/cucumber/messages-go/v16"

If it fixes an open issue #396

this should close a CVE in the above lib and allow use in orgs that scan for CVE's

Type of change

  • Refactoring

Checklist:

  • My code follows the code style of this project.
  • [-] My change requires a change to the documentation.
  • [-] I have updated the documentation accordingly.
  • [-] I have read the CONTRIBUTING document.
  • [-] I have added tests to cover my changes.
  • All new and existing tests passed.

update messages-go to v16.0.1
bump gomod version
comment on log line in std os.Stderr
examples to non rc version
go mod tidy
update circle (tbd)
@mbow
Copy link
Author

mbow commented Jun 28, 2021

@mattwynne c this should fix the issues found on the other branch.

@aslakhellesoy
Copy link
Contributor

Great work @mbow!

This looks good to me, and if you think it's ready to merge I'll do it @mbow.

We're discussing a merge of godog/gobdd over in the #committers-go channel in the Cucumber slack - any chance you could join the discussion there?

@Yellaks
Copy link

Yellaks commented Jun 29, 2021

@mbow - this looks good to me :)

@mbow
Copy link
Author

mbow commented Jun 30, 2021

@aslakhellesoy think the circle builds need to be triggered as maybe that change won't work ( new default images for circle and took a quick guess )

@mattwynne
Copy link
Member

I don't understand why CircleCI is not building this branch. I'm going to merge it anyway, and if there are any problems with the build hopefully we can just sort them out in the main branch, once you have the commit bit @mbow. Thanks a lot!

@mattwynne mattwynne merged commit 7547f42 into cucumber:main Jul 5, 2021
@aslakhellesoy
Copy link
Contributor

Hi @mbow,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@mattwynne mattwynne mentioned this pull request Jul 5, 2021
mattwynne added a commit that referenced this pull request Jul 5, 2021
@vearutop vearutop mentioned this pull request Jul 7, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants