-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
368 public formatter #372
368 public formatter #372
Conversation
- Working example where the custom formatter is built on top of the Progress formatter, using emojis instead of text
If this is a non-starter, please let me know :) |
Is this issue still in progress? |
Hi, I'm one of the Cucumber org's maintainers. We're short on regular maintainers for godog at the moment so sorry for the delay getting this reviewed. I'm happy to merge this if someone can rebase it. |
I will give it a try and test with one of my own formatters |
# Conflicts: # _examples/custom-formatter/custom.go # _examples/custom-formatter/go.mod # internal/formatters/fmt_events.go # internal/formatters/fmt_pretty.go # internal/formatters/fmt_progress.go
WIP 368 public formatter
Codecov Report
@@ Coverage Diff @@
## main #372 +/- ##
==========================================
- Coverage 83.07% 82.69% -0.39%
==========================================
Files 26 26
Lines 2511 2525 +14
==========================================
+ Hits 2086 2088 +2
- Misses 328 340 +12
Partials 97 97
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expressed my review suggestions as #418, please check if they make sense to be applied here.
Closes #368
This PR exposes Godog formatters, making them embeddable by custom formatters