-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(step_definition): Allows to define step function without return. #364
Conversation
54c41a5
to
62fb66a
Compare
Codecov Report
@@ Coverage Diff @@
## main #364 +/- ##
==========================================
+ Coverage 80.81% 84.35% +3.54%
==========================================
Files 26 26
Lines 2033 2372 +339
==========================================
+ Hits 1643 2001 +358
+ Misses 287 278 -9
+ Partials 103 93 -10
Continue to review full report at Codecov.
|
ab34950
to
81ac69d
Compare
Last commit add It can be rollbacked or adapt to keep the tests with a custom system if dependencies should not be added. |
This needs re-basing before it can be merged. @vearutop could you help? |
Issue: It is not possible to use function without return when matching steps, resulting in a lot of Nil only error returns. Fix: Allows to provide empty result function by correctly matching reflect Calls on step Handler. When nothing is returned by the Handler, it will return nil as if errors was nil.
Add tests for panic in test_context initialization. Made as independ commit so it can be rollbacked.
4acd1a7
to
63fd657
Compare
@titouanfreville do you think this PR is ready to be merged? |
Let's wait for @titouanfreville response for couple more days, otherwise this PR looks good to me to merge. |
I suggest updating the CHANGELOG as part of the PR, it's a good idea so you don't forget to do it after the merge. |
If there are no conflict, it should be ok to merge it. I also used it to start a discution arround test tools but did not get any feedback on it. I'll update the changelog ASAP before merging :) |
I'm not opposed to new testing tools (since it does not affect end-user much) if they help writing more reliable and readable tests, though not sure if goconvey brings better ergonomics compared to |
Seems @titouanfreville is busy, so I updated README and CHANGELOG and going to merge this PR. If any additional changes are necessary, let's deliver them in a separate PR. |
Issue: It is not possible to use function without return when
matching steps, resulting in a lot of Nil only error
returns.
Fix: Allows to provide empty result function by correctly matching
reflect Calls on step Handler.
When nothing is returned by the Handler, it will return
nil as if errors was nil.