Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue when go test is parsing command-line flags #359

Merged
merged 2 commits into from
Nov 26, 2020

Conversation

lonnblad
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #359 (11bd7ec) into master (69162a0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #359      +/-   ##
==========================================
+ Coverage   79.11%   79.12%   +0.01%     
==========================================
  Files          25       25              
  Lines        1992     1993       +1     
==========================================
+ Hits         1576     1577       +1     
  Misses        320      320              
  Partials       96       96              
Impacted Files Coverage Δ
flags_v0110.go 50.00% <100.00%> (+7.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69162a0...11bd7ec. Read the comment docs.

@lonnblad
Copy link
Member Author

We should try and add a test case that covers this scenario.

Copy link
Contributor

@titouanfreville titouanfreville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this solution more than adding a function that will do the trick. Think its clearer like this, less magical :)

@lonnblad lonnblad merged commit 59cd5d8 into master Nov 26, 2020
@mpkorstanje mpkorstanje deleted the fix-command-line-flags-issue branch November 26, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants