Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the README.md #302

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Updated the README.md #302

merged 1 commit into from
Jun 10, 2020

Conversation

lonnblad
Copy link
Member

@lonnblad lonnblad commented Jun 7, 2020

No description provided.

@codecov
Copy link

codecov bot commented Jun 7, 2020

Codecov Report

Merging #302 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #302   +/-   ##
=======================================
  Coverage   84.95%   84.95%           
=======================================
  Files          19       19           
  Lines        2619     2619           
=======================================
  Hits         2225     2225           
  Misses        271      271           
  Partials      123      123           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12a387e...0bd3a0e. Read the comment docs.

@lonnblad lonnblad force-pushed the updated-readme branch 2 times, most recently from 767d6a2 to ca13865 Compare June 7, 2020 13:50
@lonnblad lonnblad requested a review from mxygem June 9, 2020 20:13
Copy link
Member

@mxygem mxygem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Really the only required change is the one suggestion of on to one

README.md Outdated
always bang up-to-date.
Godog is a community driven Open Source Project within the Cucumber organization, it is maintained by a handfull of developers, but we appreciate contributions from everyone.

If you are interested in developing Godog, we suggest you to visit on of our slack channels.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you are interested in developing Godog, we suggest you to visit on of our slack channels.
If you are interested in developing Godog, we suggest you to visit one of our slack channels.

README.md Outdated

#### Less rework
## Install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the install step should be higher up, but lets see how things go here.


## Example

The following example can be [found here](/_examples/godogs).

### Step 1

Given we create a new go package **$GOPATH/src/godogs**. From now on, this
is our work directory `cd $GOPATH/src/godogs`.
Given we create a new go package **$GOPATH/src/godogs**. From now on, this is our work directory `cd $GOPATH/src/godogs`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure we want to keep the examples showing being on GOPATH?

@lonnblad lonnblad merged commit f50bd30 into master Jun 10, 2020
@lonnblad lonnblad deleted the updated-readme branch June 13, 2020 09:00
@lonnblad lonnblad restored the updated-readme branch October 19, 2020 17:01
@mattwynne mattwynne deleted the updated-readme branch April 30, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants