Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update paths to screenshots for examples #270

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Update paths to screenshots for examples #270

merged 1 commit into from
Mar 23, 2020

Conversation

leviable
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #270 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #270   +/-   ##
=======================================
  Coverage   84.04%   84.04%           
=======================================
  Files          15       15           
  Lines        2445     2445           
=======================================
  Hits         2055     2055           
  Misses        270      270           
  Partials      120      120           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d56cf10...7e432e1. Read the comment docs.

@lonnblad lonnblad merged commit 11dde19 into cucumber:master Mar 23, 2020
@aslakhellesoy
Copy link
Contributor

Hi @leviable,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@leviable leviable deleted the fix-screenshot-paths branch March 23, 2020 16:28
@lonnblad
Copy link
Member

@leviable thanks for the contribution! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants