This repository has been archived by the owner on Dec 21, 2024. It is now read-only.
Improved event bus performance using UUID generator selectable through SPI #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
mpkorstanje
reviewed
Apr 23, 2023
mpkorstanje
approved these changes
Apr 23, 2023
There was a problem hiding this comment.
I had a hard time reviewing this. The topic seems a bit out of place for the purpose of the cucumber docs which is to get people to understand the basics. But that is mostly because the plugin system hasn't been explained yet. So this is actually good enough.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
I added documentation on the UUID generator selection which was added on cucumber/cucumber-jvm#2698 .
⚡️ What's your motivation?
Documenting the UUID generator selection method clearly allows the developer to use the
IncrementingUuidGeneratorwhich is about 100 times faster than the defaultRandomUuidGenerator. This shorten the feedback loop and reduces the energy consumption.📋 Checklist: