Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cucumber-expression: Define default parameter type for quoted strings #190

Closed
aslakhellesoy opened this issue Apr 27, 2017 · 1 comment
Closed

Comments

@aslakhellesoy
Copy link
Contributor

aslakhellesoy commented Apr 27, 2017

Summary

Cucumber should recognise double-quoted strings out of the box, in a consistent way across implementations.

Expected Behavior

Consider the undefined step:

Given my "blue" coat is zipped

Cucumber should recognise "blue" as a match of a string parameter type and suggest a snippet with the following Cucumber Expression:

my {string} coat is zipped

When the step defintion is implemented, Cucumber should pass the part between the double quotes to the step definition.

Current Behavior

Cucumber.js already registers a default stringInDoubleQuotes parameter type which does all of this.

Possible Solution

Define and register this default parameter type in cucumber-expressions so Cucumber implementations don't have to do it.

Context & Motivation

The parameter type name stringInDoubleQuotes is a bit long, and won't read well in step definitions. Using string instead would make it more readable/intuitive and it would standardise the behaviour in the cucumber-expression library, avoiding inconsistent behaviour on different cucumber implementations.

@lock
Copy link

lock bot commented Oct 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant