Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

step ambiguity issue #217

Closed
aslakhellesoy opened this issue Jun 6, 2017 · 4 comments
Closed

step ambiguity issue #217

aslakhellesoy opened this issue Jun 6, 2017 · 4 comments
Labels
🐛 bug Defect / Bug

Comments

@aslakhellesoy
Copy link
Contributor

From @tony-kerz on June 6, 2017 15:44

the following step definitions:

    When('we HTTP GET "{path}"', async function(path) {
      //...
    })

    When('we HTTP GET "{path}" with query "{query}"', async function(path, query) {
      //...
    })

incurs the following:

1) Scenario: index with query - test/features/test.feature:23
   Step: When we HTTP GET "/" with query "_id=2" - test/features/test.feature:24
   Message:
     Multiple step definitions match:
       we HTTP GET "{path}"                      - src/index.js:41
       we HTTP GET "{path}" with query "{query}" - src/index.js:45

should there be implied begin-end terminators in these expressions?

Copied from original issue: cucumber/cucumber-expressions-javascript#5

@charlierudolph
Copy link
Member

To me, this requires you somehow to specify that path should not contain a double quote otherwise the resulting regex's will cause it to be ambiguous. cucumber-js has the built in transform for strings with in double quotes

@aslakhellesoy
Copy link
Contributor Author

This should no longer be an issue when #190 and #191 are fixed

@aslakhellesoy
Copy link
Contributor Author

Should be fixed in v4.0.0. Please reopen a new ticket referencing this one.

@lock
Copy link

lock bot commented Oct 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛 bug Defect / Bug
Projects
None yet
Development

No branches or pull requests

2 participants