Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/initial rubocop rework #1733

Merged
merged 14 commits into from
Sep 2, 2023
Merged

Conversation

luke-hill
Copy link
Contributor

Description

Begin to standardise all of the rubocop tech debt we have, with a few to starting to click off a few of the easy wins later on in v9.0.x

Type of change

Please delete options that are not relevant.

  • Refactoring (improvements to code design or tooling that don't change behaviour)
  • If your change may impact future contributors, explain it here, and remember to update README.md and CONTRIBUTING.md accordingly.

Please add an entry to the relevant section of CHANGELOG.md as part of this pull request.

Checklist:

Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.

  • Tests have been added for any changes to behaviour of the code
  • New and existing tests are passing locally and on CI
  • bundle exec rubocop reports no offenses
  • RDoc comments have been updated
  • CHANGELOG.md has been updated

@luke-hill luke-hill enabled auto-merge (squash) September 2, 2023 09:45
@luke-hill luke-hill merged commit 67d4d5a into main Sep 2, 2023
15 checks passed
@luke-hill luke-hill deleted the refactor/initial_rubocop_rework branch September 2, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant