-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Truffleruby support #1611
Add Truffleruby support #1611
Conversation
Their most recently public accepted PR is: digital-fabric/extralite#5 |
@@ -22,6 +22,7 @@ module Formatter | |||
@backtrace_filters << RbConfig::CONFIG['rubylibdir'] if RbConfig::CONFIG['rubylibdir'] | |||
|
|||
@backtrace_filters << 'org/jruby/' if ::Cucumber::JRUBY | |||
@backtrace_filters << '<internal:core>' if RUBY_ENGINE == "truffleruby" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eregon do you think it's safe change? It does the job (all internal errors are filtered out and tests are passing), but later on I noticed that some TypeError may dissapear as well, for example :
<internal:core> core/marshal.rb:51:in `__marshal__': singleton class can't be dumped (TypeError)
from <internal:core> core/marshal.rb:1006:in `serialize'
from <internal:core> core/marshal.rb:1309:in `dump'
from -e:1:in `<main>'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please fix the rubocop error (use single quotes), and add truffleruby to the GitHub Actions build matrix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be any path starting with <internal:
, that's also used by CRuby:
$ ruby -ve 'p method(:then).source_location'
ruby 3.0.2p107 (2021-07-07 revision 0db68f0233) [x86_64-linux]
["<internal:kernel>", 120]
Since it's converted to a Regexp later, then '^<internal:'
is best.
@gogainda it seems as though the existing CI fails some tests. I haven't got much time yet to check, but can you see if these are ones that should be passing or if this is a truffleruby nuance. |
checking, tests have passed but the process failed with:
|
Yes, looks like it: https://github.com/cucumber/cucumber-ruby/runs/4999431897?check_suite_focus=true#step:3:459 I think we need to get to the bottom of what's causing that because we merge this. We need to be confident that all tests pass on truffleruby. |
Will close it for a while until I've found a root cause |
@aslakhellesoy I've added additional workflow for rubocop job. Since output for every version is the same , we want to run it only once and leave ruby matrix only for testing |
created another PR for it #1612 |
No description provided.