Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 1595: make sure to extend the world with a valid module #1603

Merged
merged 6 commits into from
Jan 5, 2022
Merged

Fix 1595: make sure to extend the world with a valid module #1603

merged 6 commits into from
Jan 5, 2022

Conversation

aurelien-reeves
Copy link
Contributor

@aurelien-reeves aurelien-reeves commented Jan 4, 2022 •
edited
Loading

Description

Fixes #1595

Make sure to extend the World with a valid Object rather than extending it with something we think is valid but may not be.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Tests have been added for any changes to behaviour of the code
  • New and existing tests are passing locally and on CI
  • bundle exec rubocop reports no offenses
  • CHANGELOG.md has been updated

luke-hill
luke-hill reviewed Jan 5, 2022
View reviewed changes
Copy link
Contributor

@luke-hill luke-hill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a load of other optimisations but I'm going to assume that namespaced_world_modules on line140 can be an empty array so the entire line142 invocation will be an empty array iterated (i.e. nothing)

features/docs/writing_support_code/world.feature Outdated Show resolved Hide resolved
features/docs/writing_support_code/world.feature Outdated Show resolved Hide resolved
@aurelien-reeves
Copy link
Contributor Author

aurelien-reeves commented Jan 5, 2022 •
edited
Loading

Had a load of other optimisations but I'm going to assume that namespaced_world_modules on line140 can be an empty array so the entire line142 invocation will be an empty array iterated (i.e. nothing)

Could you point out some code? I don't find it myself :(
Found it

@aurelien-reeves aurelien-reeves merged commit 6e6f1a3 into main Jan 5, 2022
@aurelien-reeves aurelien-reeves deleted the fix-1595 branch January 5, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luke-hill luke-hill luke-hill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Namespaced worlds become nil after first scenario runs
2 participants
@aurelien-reeves @luke-hill