Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from create-meta to ci-environment #1601

Merged
merged 7 commits into from
Jan 4, 2022
Merged

Migrate from create-meta to ci-environment #1601

merged 7 commits into from
Jan 4, 2022

Conversation

aurelien-reeves
Copy link
Contributor

@aurelien-reeves aurelien-reeves commented Dec 29, 2021 •
edited
Loading

Description

Fixes #1596

Type of change

  • Refactoring (improvements to code design or tooling that don't change behaviour)

Please add an entry to the relevant section of CHANGELOG.md as part of this pull request.

Checklist:

Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.

  • Tests have been added for any changes to behaviour of the code
  • New and existing tests are passing locally and on CI
  • bundle exec rubocop reports no offenses
  • RDoc comments have been updated
  • CHANGELOG.md has been updated

@aurelien-reeves aurelien-reeves marked this pull request as ready for review December 29, 2021 14:23
aslakhellesoy
aslakhellesoy approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@aslakhellesoy aslakhellesoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

@aslakhellesoy aslakhellesoy merged commit af21b30 into main Jan 4, 2022
@luke-hill luke-hill deleted the update-create-meta-to-ci-env branch August 22, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslakhellesoy aslakhellesoy aslakhellesoy approved these changes

@luke-hill luke-hill Awaiting requested review from luke-hill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace create-meta with ci-environment
2 participants
@aurelien-reeves @aslakhellesoy