Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AfterConfiguration hook #1591

Merged
merged 4 commits into from
Dec 7, 2021
Merged

Conversation

aurelien-reeves
Copy link
Contributor

Description

AfterConfiguration has been deprecated in 7.1.0.
This PR removes it for 8.0.0 in favor of InstallPlugin and BeforeAll

Type of change

Please delete options that are not relevant.

  • Breaking change (will cause existing functionality to not
    work as expected)

Checklist:

Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.

  • Tests have been added for any changes to behaviour of the code
  • New and existing tests are passing locally and on CI
  • bundle exec rubocop reports no offenses
  • RDoc comments have been updated
  • CHANGELOG.md has been updated

@aurelien-reeves aurelien-reeves added this to the 8.0.0 milestone Dec 7, 2021
Copy link
Contributor

@luke-hill luke-hill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just typos

features/docs/writing_support_code/hooks/README.md Outdated Show resolved Hide resolved
features/docs/writing_support_code/hooks/README.md Outdated Show resolved Hide resolved
features/docs/writing_support_code/hooks/README.md Outdated Show resolved Hide resolved
features/docs/writing_support_code/hooks/README.md Outdated Show resolved Hide resolved
@aurelien-reeves aurelien-reeves merged commit a7e6855 into main Dec 7, 2021
@luke-hill luke-hill deleted the remove-post_configuration-hook branch August 22, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants