Remove map_column! and map_headers! #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luke-hill
reviewed
Dec 7, 2021
luke-hill
approved these changes
Dec 7, 2021
|
Just a minor note, it was probably worth including this explicitly in the v8 upgrade guide https://github.com/cucumber/cucumber-ruby/blob/main/UPGRADING.md#upgrading-to-800 . It mentions that map_column has had an argument switch from positional to keyword, but not that map_column! was removed :). I'll make a PR if I can find some time today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1584
Type of change
Please delete options that are not relevant.
work as expected)
Checklist:
Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.
addedremoved :D for any changes to behaviour of the codebundle exec rubocopreports no offenses