Skip to content

Commit

Permalink
Clean spaces that are not real spaces
Browse files Browse the repository at this point in the history
  • Loading branch information
vincent-psarga committed Oct 29, 2019
1 parent 907f779 commit a7e2a93
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions lib/cucumber/wire/add_hooks_filter.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ def test_case(test_case)
end

def before_hook(test_case)
# TODO: is this dependency on Cucumber::Hooks OK? Feels a bit internal..
# TODO: how do we express the location of the hook? Should we create one hook per connection so we can use the host:port of the connection?
# TODO: is this dependency on Cucumber::Hooks OK? Feels a bit internal..
# TODO: how do we express the location of the hook? Should we create one hook per connection so we can use the host:port of the connection?
Cucumber::Hooks.before_hook(Core::Test::Location.new('TODO:wire')) do
connections.begin_scenario(test_case)
end
Expand Down
2 changes: 1 addition & 1 deletion lib/cucumber/wire/connections.rb
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def initialize(connections, configuration, registry)
def find_match(test_step)
matches = step_matches(test_step.name)
return unless matches.any?
# TODO: handle ambiguous matches (push to cucumber?)
# TODO: handle ambiguous matches (push to cucumber?)
matches.first
end

Expand Down
2 changes: 1 addition & 1 deletion lib/cucumber/wire/protocol/requests.rb
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def handle_pending(message)
end

def handle_diff!(tables)
# TODO: figure out if / how we could get a location for a table from the wire (or make a null location)
# TODO: figure out if / how we could get a location for a table from the wire (or make a null location)
location = Core::Test::Location.new(__FILE__, __LINE__)
table1 = table(tables[0], location)
table2 = table(tables[1], location)
Expand Down

0 comments on commit a7e2a93

Please sign in to comment.