Additional gemspec cleanup #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundler was getting confused trying to resolve the builder dependency, so we specify a dependency even though there is no direct dependency. This can be removed when the issue is fixed in bundler or if we no longer depend on any other gems that depend on builder.
Kosmas
added a commit
that referenced
this pull request
Sep 18, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #264, this fixes some inconsistencies in the gemspec and adds upper bounds to runtime constraints.
For more on this, please read: http://yehudakatz.com/2010/08/21/using-considered-harmful-or-whats-wrong-with/
In my opinion, this advice only applies to runtime dependencies. Development dependencies don't need strict versioning because they do not affect end-users.