Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep empty step_definitions directories #249

Merged
merged 6 commits into from
Feb 6, 2014

Conversation

ibroadfo
Copy link
Contributor

@ibroadfo ibroadfo commented Jun 4, 2013

No description provided.

@Kosmas
Copy link
Member

Kosmas commented Jun 5, 2013

Hi @ibroadfo, thanks for the PR.

Trying to get the rails4 compatibility working at the moment.
When that is place and if @mattwynne, and @aslakhellesoy do not have any objections, will merge it afterwards.
Cannot do it at the moment as it seems that the tests are failing for the master branch.

@aslakhellesoy
Copy link
Contributor

LGTM

@Kosmas
Copy link
Member

Kosmas commented Jul 10, 2013

@ibroadfo the travis tests fail

https://travis-ci.org/cucumber/cucumber-rails/builds/7781307

Have a look at the master_rails4_test branch because the problem with the connection is fixed there, as well as the warning about 'cucumber-rails required outside ...'

https://github.com/cucumber/cucumber-rails/blob/master_rails4_test/features/step_definitions/cucumber_rails_steps.rb

@Kosmas
Copy link
Member

Kosmas commented Feb 5, 2014

Closing old issues. If they are still relevant, please reopen

@Kosmas Kosmas closed this Feb 5, 2014
@ibroadfo
Copy link
Contributor Author

ibroadfo commented Feb 5, 2014

reopening, i've rebased my branch and everything passes locally; fingers crossed the travis gods smile on me this time. 😺

@ibroadfo
Copy link
Contributor Author

ibroadfo commented Feb 5, 2014

oh, wait there is no 'reopen' button. 😊 will this PR magically pick up my rebased branch or should i open a fresh one?

@Kosmas Kosmas reopened this Feb 5, 2014
@Kosmas
Copy link
Member

Kosmas commented Feb 5, 2014

I've reopened it.
We just have to wait for Travis now.
Thanks.

@ibroadfo
Copy link
Contributor Author

ibroadfo commented Feb 5, 2014

failing with same error as #272 ? but only on 1.9.3/rails4.

😖

@ibroadfo
Copy link
Contributor Author

ibroadfo commented Feb 5, 2014

well, it failed once: https://travis-ci.org/cucumber/cucumber-rails/builds/18290634 but then passed. i blame the phase of the moon?

Kosmas added a commit that referenced this pull request Feb 6, 2014
@Kosmas Kosmas merged commit 1a47534 into cucumber:master Feb 6, 2014
Kosmas added a commit that referenced this pull request Feb 6, 2014
merged pull request #249 - keep empty step_definitions directories
@Kosmas
Copy link
Member

Kosmas commented Feb 6, 2014

All good @ibroadfo .

Thanks a lot.

@ibroadfo ibroadfo deleted the keep_empty_step_definitions_dir branch February 6, 2014 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants