-
-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keep empty step_definitions directories #249
keep empty step_definitions directories #249
Conversation
Hi @ibroadfo, thanks for the PR. Trying to get the rails4 compatibility working at the moment. |
LGTM |
@ibroadfo the travis tests fail https://travis-ci.org/cucumber/cucumber-rails/builds/7781307 Have a look at the master_rails4_test branch because the problem with the connection is fixed there, as well as the warning about 'cucumber-rails required outside ...' |
…c-database-cleaning Ensure dependency on DatabaseCleaner is not required
Amend typo in select_dates_and_times.rb comments.
Closing old issues. If they are still relevant, please reopen |
reopening, i've rebased my branch and everything passes locally; fingers crossed the travis gods smile on me this time. 😺 |
oh, wait there is no 'reopen' button. 😊 will this PR magically pick up my rebased branch or should i open a fresh one? |
I've reopened it. |
failing with same error as #272 ? but only on 1.9.3/rails4. 😖 |
well, it failed once: https://travis-ci.org/cucumber/cucumber-rails/builds/18290634 but then passed. i blame the phase of the moon? |
keep empty step_definitions directories
merged pull request #249 - keep empty step_definitions directories
All good @ibroadfo . Thanks a lot. |
No description provided.