Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default javascript database strategy should be truncation #182

Closed
mattwynne opened this issue Nov 3, 2011 · 5 comments
Closed

Default javascript database strategy should be truncation #182

mattwynne opened this issue Nov 3, 2011 · 5 comments

Comments

@mattwynne
Copy link
Member

See #166

Right now the default is to use a shared connection, but since this isn't thread safe and causes hard-to-understand errors it's probably better to default to truncation instead. However, when I tried that, it made features fail. This ticket will remind us to change the defaults and fix the features.
@aslakhellesoy
Copy link
Contributor

AFAICT the default is truncation: fe08386

@mattwynne
Copy link
Member Author

Ah OK, you set it in the generator. That's probably clearer.

I also set it here, you see:
https://github.com/cucumber/cucumber-rails/blob/master/lib/cucumber/rails/database.rb#L64

@aslakhellesoy
Copy link
Contributor

Yeah - let's remove that. You fix?

@jdelStrother jdelStrother mentioned this issue Nov 4, 2011
Closed
@aslakhellesoy
Copy link
Contributor

This has been fixed

@aslakhellesoy aslakhellesoy reopened this Dec 4, 2011
betelgeuse added a commit to betelgeuse/cucumber-rails that referenced this issue Jul 31, 2012
@betelgeuse
Fix documentation for javascript clean strategy
4aec8db 
The code uses truncation as the default so that comment in the cucumber
feature is wrong. For more information on the default strategy see for
example cucumber#182.
@betelgeuse betelgeuse mentioned this issue Jul 31, 2012
Merged
@Kosmas
Copy link
Member

Kosmas commented Feb 5, 2014

Closing old issues. If they are still relevant, please reopen

@Kosmas Kosmas closed this as completed Feb 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aslakhellesoy @Kosmas @mattwynne