Call all formatters, also when using the IntelliJ's internal formatter. #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IntelliJ formatter does not implement the startOfScenarioLifeCycle and the endOfScenarioLifeCycle methods. Also when it is throwing an exception on these methods, all other formatters used need to be called on these methods.
brasmusson
force-pushed
the
formatter-error-handling
branch
from
d88aa0f to
1e573f5
Compare
|
LGTM! |
brasmusson
added a commit
that referenced
this pull request
Mar 18, 2015
Merge #842 "Call all formatters, also when using the IntelliJ's internal formatter."
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IntelliJ's internal formatter does not implement the startOfScenarioLifeCycle and the endOfScenarioLifeCycle methods. The current handling of this has the side effect, that all other formatters (after the IntelliJ one in the plugin list), will not receive calls to these methods, see #803.
This PR changes the handling of exceptions from the the startOfScenarioLifeCycle and the endOfScenarioLifeCycle methods of formatters, so that also in this case all formatters will receive calls to these methods.
Fixes #803.