Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

killed android profile and moved android project to default profile #821

Conversation

SierraGolf
Copy link
Contributor

No description provided.

@brasmusson
Copy link
Contributor

Good job. Some small comments:
The file .travis_android_update should be removed, it was only used from the now deleted android job on Travis.
Several of the README.md (android/README.md, examples/android/README.md, examples/android/android-test/README.md, examples/android/cukeulator-test/README.md I think) specify -P android or -P android,android-examples in mvn command, which now become obsolete.

@SierraGolf
Copy link
Contributor Author

good points, I will clean that up

@SierraGolf SierraGolf force-pushed the sierragolf/add-android-to-default-profile branch 2 times, most recently from 96a4d63 to 4fea0c0 Compare January 9, 2015 08:12
@SierraGolf
Copy link
Contributor Author

@aslakhellesoy anything against merging this PR?

@aslakhellesoy
Copy link
Contributor

LGTM

@SierraGolf SierraGolf force-pushed the sierragolf/add-android-to-default-profile branch from d0f7718 to 8e7147c Compare January 11, 2015 17:21
SierraGolf added a commit that referenced this pull request Jan 11, 2015
…ault-profile

killed android profile and moved android project to default profile
@SierraGolf SierraGolf merged commit cef5703 into cucumber:master Jan 11, 2015
@SierraGolf SierraGolf deleted the sierragolf/add-android-to-default-profile branch January 11, 2015 17:49
@aslakhellesoy
Copy link
Contributor

@SierraGolf don't forget to credit yourself (and others) in History.md.

@SierraGolf
Copy link
Contributor Author

will do

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants