Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce a minimum build environment of JDK 1.7 and maven 3.1.1 #692

Merged
merged 2 commits into from
Mar 20, 2014

Conversation

nhajratw
Copy link
Contributor

This may or may not work on the travis-ci build.

@nhajratw
Copy link
Contributor Author

OK .. well, even though travis-ci seems to be using maven 3.1.1, it doesn't complain with the min maven version set to 3.2.1. It looks like the new way to do this versioning is via the enforcer plugin. I'm adding the enforcer now with a value of 3.1.1

@nhajratw nhajratw changed the title bumped min maven version to 3.2.1 enforce a minimum build environment of JDK 1.7 and maven 3.1.1 Mar 20, 2014
@nhajratw
Copy link
Contributor Author

Looks like it's good to go! 👍

aslakhellesoy added a commit that referenced this pull request Mar 20, 2014
enforce a minimum build environment of JDK 1.7 and maven 3.1.1
@aslakhellesoy aslakhellesoy merged commit 0086dce into cucumber:master Mar 20, 2014
@aslakhellesoy
Copy link
Contributor

Holy crap what load of XML. I'm speechless.

@nhajratw
Copy link
Contributor Author

Yay maven! :-) Ready to convert the project to Buildr? ;-)

@aslakhellesoy
Copy link
Contributor

We'll stick with Maven. Not because it's great, but it's what most people know and IDEs have good support with it.

We have spent a lot of time getting the Maven build to where it is and I'd rather not burn a week migrating to a new build system ;-)

We tried Ivy a couple of years ago and it was horrible.

@nhajratw
Copy link
Contributor Author

agreed.

@nhajratw nhajratw deleted the min-maven-version branch March 20, 2014 15:52
@dkowis
Copy link
Member

dkowis commented Mar 21, 2014

/me pimps gradle again ;)

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants