-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The first TestNG "native" integration. #526
Conversation
The simplest usage: import cucumber.api.testng.AbstractTestNGCucumberTests; public class RunCukesTest extends AbstractTestNGCucumberTests { } Note: Maybe there should be a more appropriate TestNG reporter for Cucumber.
Hello! //cc @SebTardif, @aslakhellesoy, @gimlet2, @maxnajim, @pranasblk |
Are there any comments? |
runtime.run(); | ||
|
||
if (!runtime.getErrors().isEmpty()) { | ||
throw new RuntimeException(runtime.getErrors().get(0)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe throw CucumberException here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally agree.
@igorvsd could you, please, participate in the issue? |
public void uri(String uri) { | ||
// TODO: find an appropriate keyword | ||
String keyword = "Feature File"; | ||
logDiv(keyword, uri, "featureFile"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There would be nice to find an appropriate keyword source here.
@aslakhellesoy I think the proposal may be postponed to the next release to not delay current one. |
JFYI This PL is just a "naive" TestNG implementation, it was written just to kickstart TestNG integration. It's waiting for resolution. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
The simplest usage:
Note: Maybe there should be a more appropriate TestNG reporter for Cucumber.
This is an integration with some minor changes of the https://github.com/lionhearth/cucumber-testng implementation by @igorvsd and @gimlet2
Related to the #441 issue.