Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The first TestNG "native" integration. #526

Merged
merged 2 commits into from
Aug 15, 2013
Merged

The first TestNG "native" integration. #526

merged 2 commits into from
Aug 15, 2013

Conversation

ffbit
Copy link
Contributor

@ffbit ffbit commented May 20, 2013

The simplest usage:

import cucumber.api.testng.AbstractTestNGCucumberTests;

public class RunCukesTest extends AbstractTestNGCucumberTests {
}

Note: Maybe there should be a more appropriate TestNG reporter for Cucumber.

This is an integration with some minor changes of the https://github.com/lionhearth/cucumber-testng implementation by @igorvsd and @gimlet2

Related to the #441 issue.

The simplest usage:

    import cucumber.api.testng.AbstractTestNGCucumberTests;

    public class RunCukesTest extends AbstractTestNGCucumberTests {
    }

Note: Maybe there should be a more appropriate TestNG reporter for Cucumber.
@ffbit
Copy link
Contributor Author

ffbit commented May 28, 2013

Hello!
Any comments/suggestions on The first TestNG "native" integration proposal?

//cc @SebTardif, @aslakhellesoy, @gimlet2, @maxnajim, @pranasblk

@ffbit
Copy link
Contributor Author

ffbit commented Jul 22, 2013

Are there any comments?

runtime.run();

if (!runtime.getErrors().isEmpty()) {
throw new RuntimeException(runtime.getErrors().get(0));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe throw CucumberException here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree.

@ffbit
Copy link
Contributor Author

ffbit commented Jul 27, 2013

@igorvsd could you, please, participate in the issue?

public void uri(String uri) {
// TODO: find an appropriate keyword
String keyword = "Feature File";
logDiv(keyword, uri, "featureFile");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There would be nice to find an appropriate keyword source here.

@ffbit
Copy link
Contributor Author

ffbit commented Jul 28, 2013

@aslakhellesoy I think the proposal may be postponed to the next release to not delay current one.

@ffbit
Copy link
Contributor Author

ffbit commented Aug 1, 2013

JFYI

This PL is just a "naive" TestNG implementation, it was written just to kickstart TestNG integration.
Maybe someone will decide to implement and improve the code somehow.

It's waiting for resolution.

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants