[Pico] Fixed UnsatisfiableDependencyException with Component dependencies

[jkronegg]

🤔 What's changed?

Classes registration in picoccontainer have changed from order top->down to bottom-up, which is required when one class in the hierarchy implements Disposable.

⚡️ What's your motivation?

Fixes #2762

🏷️ What kind of change is this?

• 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

N/A

📋 Checklist:

• I agree to respect and uphold the Cucumber Community Code of Conduct
• I've changed the behaviour of the code
  • I have added/updated tests to cover my changes.
• My change requires a change to the documentation.
  • I have updated the documentation accordingly.
• Users should know about my change
  • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

[codecov]

Codecov Report

Merging #2764 (531d961) into main (383ab6d) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #2764   +/-   ##
=========================================
  Coverage     84.98%   84.98%           
  Complexity     2725     2725           
=========================================
  Files           331      331           
  Lines          9537     9537           
  Branches        914      914           
=========================================
  Hits           8105     8105           
  Misses         1108     1108           
  Partials        324      324           

Impacted Files	Coverage Δ
...in/java/io/cucumber/picocontainer/PicoFactory.java	95.65% <100.00%> (ø)

[mpkorstanje]

Code wise, no remarks.

I suppose you have to register bottom up now because the container has been started already?

[jkronegg]

I suppose you have to register bottom up now because the container has been started already?

Yes, exactly. As the container has already been started, it tries to create a component instance of the FirstComponent, but this doesn't work because the SecondComponent class is not yet registered. By registering the classes from the constructor parameters first, the SecondComponent is registered when the container creates the FirstComponent instance.

I don't know why is the behaviour different depending on whether the Disposable interface is implemented or not...

[jkronegg]

@mpkorstanje can you merge the pull request if everything is fine please ?