Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Add ParameterType message source reference #2739

Merged
merged 4 commits into from
Apr 23, 2023

Conversation

jkronegg
Copy link
Contributor

@jkronegg jkronegg commented Apr 19, 2023

🤔 What's changed?

The ParameterType emited on the event bus contains now the SourceReference.

⚡️ What's your motivation?

Fixes #2719

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

N/A

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #2739 (49b581d) into main (2f90ebf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #2739   +/-   ##
=========================================
  Coverage     85.01%   85.01%           
  Complexity     2726     2726           
=========================================
  Files           331      331           
  Lines          9561     9565    +4     
  Branches        914      914           
=========================================
+ Hits           8128     8132    +4     
  Misses         1110     1110           
  Partials        323      323           
Impacted Files Coverage Δ
...main/java/io/cucumber/core/runner/CachingGlue.java 98.19% <100.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jkronegg jkronegg requested a review from mpkorstanje April 19, 2023 06:37
@mpkorstanje mpkorstanje changed the title Added ParameterType message source reference [Core] Add ParameterType message source reference Apr 23, 2023
@mpkorstanje mpkorstanje merged commit 1ff745b into main Apr 23, 2023
@mpkorstanje mpkorstanje deleted the parametertype-message-sourcereference branch April 23, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add source reference on Envelope.parameterType
2 participants