-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Read rerun files from directories #2710
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Now there are a few more things that need to be done before this can be merged.
- Write some tests.
- Clean up the code
- Update the
CHANGELOG.md
Once that is done the feature can be released.
Writing tests
The test for this class would go into the CucumberPropertiesParserTest
. There already is a test for should_parse_rerun_file
so you can use that to pattern a few more tests. I reckon the important cases are a directory with no files and a directory with two files.
These tests will make the next part easier.
Cleaning up the code
I've left some comments on the code itself. They'll make the code a bit better.
Update the CHANGELOG
In the CHANGELOG.md
file you can add a ### Fixed
header and add an entry for your change. Have a look at the older entries to see the format used.
cucumber-core/src/main/java/io/cucumber/core/options/CucumberPropertiesParser.java
Outdated
Show resolved
Hide resolved
cucumber-core/src/main/java/io/cucumber/core/options/CucumberPropertiesParser.java
Outdated
Show resolved
Hide resolved
Pushed some changes. Still have to update the docs on |
Codecov Report
@@ Coverage Diff @@
## main #2710 +/- ##
============================================
+ Coverage 84.99% 85.01% +0.01%
- Complexity 2724 2726 +2
============================================
Files 330 331 +1
Lines 9555 9561 +6
Branches 915 914 -1
============================================
+ Hits 8121 8128 +7
+ Misses 1111 1110 -1
Partials 323 323
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Hi @dbfwhitney, Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾 In return for this generous offer we hope you will:
On behalf of the Cucumber core team, |
@dbfwhitney thanks for the first setup. |
Added a method to try and add functionality to process all rerun folders in a directory (if more than 0 files exist). Still needs work as not sure how to implement walkFileTree method.