Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates in the Java Backend API to improve reusability #257

Closed
wants to merge 1 commit into from

Conversation

jeromebenois
Copy link

Could you open more your Java Backend API in order to improve reusability? I need to call two internal methods in my Cucumber's Play'Framework plugin.

Thanks,
Jérôme.

@aslakhellesoy
Copy link
Contributor

Thanks for that Jérôme. Is your Cucumber Play plugin source available anywhere?

@jeromebenois
Copy link
Author

Yes I plan to publish next week on my GitHub on Apache2 license. Are you interested?

@aslakhellesoy
Copy link
Contributor

I won't be using Play, but I'm interested in looking at the code.

@jeromebenois
Copy link
Author

@aslakhellesoy
Copy link
Contributor

@jeromebenois I ended up doing this a little differently. I don't want to open up too much of the internals because it makes it harder to refactor in the future.

Now you should be able to simply do this in your PlayBackend (not tested):

for (Method method : glueCodeClass.getMethods()) {
    loadGlue(glue, method);
}           

Does that work for you?

hutchy2570 pushed a commit to lgi-kitd/cucumber-jvm that referenced this pull request Mar 21, 2012
@jeromebenois
Copy link
Author

Thanks, It works !

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants