Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Remove usage of Collectors.toUnmodifiableList #2531

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Apr 20, 2022

Collectors.toUnmodifiableList was introduced since java 10. Which is slightly too modern for us to use.

Fixes #2530

🏷️ What kind of change is this?

  • πŸ› Bug fix (non-breaking change which fixes a defect)

πŸ“‹ Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@mpkorstanje mpkorstanje force-pushed the remove-since-java-10-method branch from 52f5598 to 24564df Compare April 20, 2022 18:49
@mpkorstanje mpkorstanje changed the title Remove usage of since java 10 Collectors.toUnmodifiableList [Core] Remove usage of since java 10 Collectors.toUnmodifiableList Apr 20, 2022
@mpkorstanje mpkorstanje changed the title [Core] Remove usage of since java 10 Collectors.toUnmodifiableList [Core] Remove usage of Collectors.toUnmodifiableList Apr 20, 2022
@mpkorstanje mpkorstanje merged commit e7239db into main Apr 20, 2022
@mpkorstanje mpkorstanje deleted the remove-since-java-10-method branch April 20, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cucumber-java8 : 7.3.0 uses java10 method Collectors.toUnmodifiableList
1 participant