Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Display curl-like error message for more url output stream problems #2451

Merged
merged 1 commit into from
Jan 1, 2022

Conversation

mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Jan 1, 2022

Fixes: #2307

@mpkorstanje mpkorstanje force-pushed the improve-exceptions-on-outputstream branch from 422bb0c to 3d44377 Compare January 1, 2022 22:09
@mpkorstanje mpkorstanje added this to the v7.x.x milestone Jan 1, 2022
@codecov
Copy link

codecov bot commented Jan 1, 2022

Codecov Report

Merging #2451 (8cd03b0) into main (f0b5641) will decrease coverage by 0.04%.
The diff coverage is 64.70%.

❗ Current head 8cd03b0 differs from pull request most recent head de1377e. Consider uploading reports for the commit de1377e to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2451      +/-   ##
============================================
- Coverage     83.71%   83.67%   -0.05%     
- Complexity     2663     2665       +2     
============================================
  Files           319      319              
  Lines          9396     9408      +12     
  Branches        909      909              
============================================
+ Hits           7866     7872       +6     
- Misses         1193     1199       +6     
  Partials        337      337              
Impacted Files Coverage Δ
.../java/io/cucumber/core/plugin/UrlOutputStream.java 81.48% <64.70%> (-5.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0b5641...de1377e. Read the comment docs.

@mpkorstanje mpkorstanje marked this pull request as ready for review January 1, 2022 22:15
@mpkorstanje mpkorstanje force-pushed the improve-exceptions-on-outputstream branch from 3d44377 to 8cd03b0 Compare January 1, 2022 22:17
@mpkorstanje mpkorstanje force-pushed the improve-exceptions-on-outputstream branch from 8cd03b0 to de1377e Compare January 1, 2022 22:23
@mpkorstanje mpkorstanje merged commit 49a336d into main Jan 1, 2022
@mpkorstanje mpkorstanje deleted the improve-exceptions-on-outputstream branch January 1, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error message when SSL exception occurs during publishing
1 participant