Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Remove excess hyphens in USAGE.txt #1347

Merged
merged 1 commit into from
Apr 20, 2018

Conversation

janosvitok
Copy link
Contributor

Summary

Some of the options in the USAGE.txt have description in format --[no-]-something.
Last hyphen should not be there: the correct format is --[no-]something

Note: https://cucumber.io/docs/reference/jvm#configuration needs update as well

How Has This Been Tested?

No tests, it's a small docs typo fix.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • [x ] I have updated the documentation accordingly.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.595% when pulling 80bae01 on janosvitok:fix-cli-usage into f42079a on cucumber:master.

@mpkorstanje
Copy link
Contributor

Cheers!

@mpkorstanje mpkorstanje merged commit 8dcf131 into cucumber:master Apr 20, 2018
@aslakhellesoy
Copy link
Contributor

Hi @janosvitok,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@mpkorstanje
Copy link
Contributor

Note: https://cucumber.io/docs/reference/jvm#configuration needs update as well

Done. Whole new website. :)

@lock
Copy link

lock bot commented Apr 20, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 20, 2019
@janosvitok janosvitok deleted the fix-cli-usage branch November 5, 2019 23:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants