[TestNG] Always map Pickles/TestCases to TestNG tests. #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the support for mapping the whole Cucumber test suite or each Cucumber feature to TestNG tests.
mpkorstanje
reviewed
Apr 1, 2018
| * | ||
| * @see AbstractTestNGCucumberTests#runScenario(cucumber.api.testng.PickleEventWrapper, cucumber.api.testng.CucumberFeatureWrapper) | ||
| */ | ||
| public class PickleEventWrapperImpl implements PickleEventWrapper { |
There was a problem hiding this comment.
This should probably be package private.
mpkorstanje
reviewed
Apr 1, 2018
There was a problem hiding this comment.
Do we want to expose TestNGCucumberRunner as part of the public api?
Nevermind. It appears we do. f27890e
mpkorstanje
reviewed
Apr 1, 2018
|
|
Everything else looks good to me. |
mpkorstanje
force-pushed
the
testng-run-pickles-only
branch
from
566da65 to
cb10e75
Compare
|
I'm moving the read me to a separate PR so I can also include #1338. |
mpkorstanje
approved these changes
Apr 1, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Always map Pickles/TestCases to TestNG tests.
Details
Remove the support for mapping the whole Cucumber test suite or each Cucumber feature to TestNG tests.
Motivation and Context
The first TestNG support implemented in Cucumber-JVM mapped the whole Cucumber test suite to one TestNG test. It did enable running Cucumber from a TestNG runner, but did provide practically no notification of the result in the TestNG domain.
Later the TestNG support was expanded to allow the mapping of each Cucumber feature (file) to a TestNG test. It provided a little better notification of the result in the TestNG domain, but it was still limited.
Now the natural mapping, one Pickle/TestCase to one TestNG test, is supported, and a major release is on the way, the legacy support for mapping the whole Cucumber test suite or each Cucumber feature to TestNG tests should be removed.
How Has This Been Tested?
The automated test suite has been updated to cover the remaining behavior.
Types of changes
Checklist: