Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Remove 'dummy' results from junit formatter #1331

Merged
merged 1 commit into from
Mar 9, 2018

Conversation

kutzi
Copy link
Contributor

@kutzi kutzi commented Mar 8, 2018

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 81.513% when pulling acdee29 on kutzi:remove_dummy_results into 1eb7d39 on cucumber:master.

@mpkorstanje mpkorstanje added this to the 3.0.0 milestone Mar 9, 2018
@mpkorstanje mpkorstanje changed the title don't write 'dummy' results when no tests ran [Core] Remove 'dummy' results from junit formatter Mar 9, 2018
@mpkorstanje mpkorstanje merged commit 23ce675 into cucumber:master Mar 9, 2018
@aslakhellesoy
Copy link
Contributor

Hi @kutzi,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@mpkorstanje
Copy link
Contributor

Cheers!

@kutzi kutzi deleted the remove_dummy_results branch March 10, 2018 09:33
@lock
Copy link

lock bot commented Mar 10, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants