[Core] Use cucumber-ruby rerun file specification #1187
Conversation
Implemented the rerun file specification from cucumber ruby[1]. It handles spaces, new lines as a separator as well as no separator at all. References: [1] https://github.com/cucumber/cucumber-ruby/blame/master/lib/cucumber/cli/rerun_file.rb
|
|
||
| public class CucumberFeature implements Serializable { | ||
| private static final long serialVersionUID = 1L; | ||
| private final String uri; | ||
| private String language; | ||
| private GherkinDocument gherkinDocument; | ||
| private String gherkinSource; | ||
| public static final Pattern RERUN_PATH_SPECIFICATION = Pattern.compile("(?m:^| |)(.*?\\.feature(?:(?::\\d+)*))"); |
There was a problem hiding this comment.
?m: for multi line or this input:
/some/path/foo.feature
[space]/some/path/foo.feature
Will yield: ["/some/path/foo.feature", "/some/path/bar.feature"].
Not sure if this actually a bad thing though.
| @@ -71,7 +66,10 @@ private static void loadFromRerunFile(FeatureBuilder builder, ResourceLoader res | |||
| for (Resource resource : resources) { | |||
| String source = read(resource); | |||
| if (!source.isEmpty()) { | |||
| featurePaths.addAll(Arrays.asList(source.split(" "))); | |||
There was a problem hiding this comment.
Not sure how I missed this the first time round. Nasty duplication.
There was a problem hiding this comment.
With Gherkin v2 the filters were passed to the parser and the filtering was done there, so it was straightforward to add the line filters from the rerun file to the filters passed through the load method. Now with Gherkin v4 the filtering is instead done after the compiling of the features to pickles, so we are actually reading the rerun file twice, once to find the feature files to be parsed, and once to get the line filters to the pickle filter chain. This duplication was probably caused by that those two used was fixed at different times in the work or upgrading to Gherkin v4 (and the extract method refactoring missed).
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Implemented the rerun file specification from cucumber ruby[1]. It
handles spaces, new lines as a separator as well as no separator at all.
References:
[1] https://github.com/cucumber/cucumber-ruby/blame/master/lib/cucumber/cli/rerun_file.rb
Types of changes
Checklist: